Re: [PATCH v3 3/5] dt-bindings: stm32: add clocks and reset binding for stm32mp25 platform

[Gabriel FERNANDEZ]

On 11/22/23 20:03, Krzysztof Kozlowski wrote:
> On 22/11/2023 14:21, gabriel.fernandez@xxxxxxxxxxx wrote:
> > From: Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxxx>
> >
> > Adds clock and reset binding entries for STM32MP25 SoC family
> >
> > Signed-off-by: Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxxx>
> > ---
> >   .../bindings/clock/st,stm32mp25-rcc.yaml      |  76 +++
> >   include/dt-bindings/clock/st,stm32mp25-rcc.h  | 492 ++++++++++++++++++
> >   include/dt-bindings/reset/st,stm32mp25-rcc.h  | 165 ++++++
> >   3 files changed, 733 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/clock/st,stm32mp25-rcc.yaml
> >   create mode 100644 include/dt-bindings/clock/st,stm32mp25-rcc.h
> >   create mode 100644 include/dt-bindings/reset/st,stm32mp25-rcc.h
> >
> > diff --git a/Documentation/devicetree/bindings/clock/st,stm32mp25-rcc.yaml b/Documentation/devicetree/bindings/clock/st,stm32mp25-rcc.yaml
> > new file mode 100644
> > index 000000000000..8697ab6bc22c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/st,stm32mp25-rcc.yaml
> > @@ -0,0 +1,76 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/st,stm32mp25-rcc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: STM32MP25 Reset Clock Controller
> > +
> > +maintainers:
> > +  - Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxxx>
> > +
> > +description: |
> > +  The RCC hardware block is both a reset and a clock controller.
> > +  RCC makes also power management (resume/supend).
> > +
> > +  See also::
> > +    include/dt-bindings/clock/st,stm32mp25-rcc.h
> > +    include/dt-bindings/reset/st,stm32mp25-rcc.h
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - st,stm32mp25-rcc
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  '#clock-cells':
> > +    const: 1
> > +
> > +  '#reset-cells':
> > +    const: 1
> > +
> > +  clocks:
> > +    items:
> > +      - description: CK_SCMI_HSE High Speed External oscillator (8 to 48 MHz)
> > +      - description: CK_SCMI_HSI High Speed Internal oscillator (~ 64 MHz)
> > +      - description: CK_SCMI_MSI Low Power Internal oscillator (~ 4 MHz or ~ 16 MHz)
> > +      - description: CK_SCMI_LSE Low Speed External oscillator (32 KHz)
> > +      - description: CK_SCMI_LSI Low Speed Internal oscillator (~ 32 KHz)
> > +
> > +  clock-names:
> > +    items:
> > +      - const: hse
> > +      - const: hsi
> > +      - const: msi
> > +      - const: lse
> > +      - const: lsi
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - "#clock-cells"
> > +  - "#reset-cells"
> If there is going to be respin, please use consistent quotes: either '
> or ", in each place. No need to respin only for this.
>
> ...
ok i will use '
> > diff --git a/include/dt-bindings/clock/st,stm32mp25-rcc.h b/include/dt-bindings/clock/st,stm32mp25-rcc.h
> > new file mode 100644
> > index 000000000000..9876ee0dd1e4
> > --- /dev/null
> > +++ b/include/dt-bindings/clock/st,stm32mp25-rcc.h
> > @@ -0,0 +1,492 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-3-Clause */
> Any particular reason why do you need 3-clause BSD? Checkpatch asks for
> different one, because that one clause is just annoying.

Yes, the same file can also be used in other components, such as 
TF-A/OPTEE, and can therefore have a dual licence.


> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> Best regards,
> Krzysztof
Thanks

Best Regards,

Gabriel