Re: [PATCH v2 8/9] arm64: dts: qcom: ipq5332: add support for the NSSCC

[Kathiravan Thirumoorthy]

On 11/23/2023 1:52 AM, Konrad Dybcio wrote:
> On 11/21/23 15:30, Kathiravan Thirumoorthy wrote:
> > Describe the NSS clock controller node and it's relevant external
> > clocks.
> >
> > Signed-off-by: Kathiravan Thirumoorthy <quic_kathirav@xxxxxxxxxxx>
> > ---
> > Changes in V2:
> >     - Update the node names with proper suffix
> > ---
> >   arch/arm64/boot/dts/qcom/ipq5332.dtsi | 28 ++++++++++++++++++++++++++++
> >   1 file changed, 28 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi 
> > b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> > index 42e2e48b2bc3..5cbe72f03869 100644
> > --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> > @@ -15,6 +15,18 @@ / {
> >       #size-cells = <2>;
> >       clocks {
> > +        cmn_pll_nss_200m_clk: cmn-pll-nss-200m-clk {
> > +            compatible = "fixed-clock";
> > +            clock-frequency = <200000000>;
> > +            #clock-cells = <0>;
> > +        };
> > +
> > +        cmn_pll_nss_300m_clk: cmn-pll-nss-300m-clk {
> > +            compatible = "fixed-clock";
> > +            clock-frequency = <300000000>;
> > +            #clock-cells = <0>;
> > +        };
> > +
> >           sleep_clk: sleep-clk {
> >               compatible = "fixed-clock";
> >               #clock-cells = <0>;
> > @@ -473,6 +485,22 @@ frame@b128000 {
> >                   status = "disabled";
> >               };
> >           };
> > +
> > +        nsscc: clock-controller@39b00000{
> > +            compatible = "qcom,ipq5332-nsscc";
> > +            reg = <0x39b00000 0x80000>;
> > +            clocks = <&cmn_pll_nss_200m_clk>,
> > +                 <&cmn_pll_nss_300m_clk>,
> > +                 <&gcc GPLL0_OUT_AUX>,
> > +                 <0>,
> > +                 <0>,
> > +                 <0>,
> > +                 <0>,
> > +                 <&xo_board>;
> > +            #clock-cells = <0x1>;
> > +            #reset-cells = <0x1>;
> 0x1 -> 1, it's a number and not a register

Thanks for pointing it out, will fix it in next spin.
> Konrad