Re: [Patch v2] thunderbolt: Add quirk to reset downstream port

From: Mika Westerberg
Date: Thu Nov 23 2023 - 01:57:57 EST


On Thu, Nov 23, 2023 at 12:23:36AM -0600, Mario Limonciello wrote:
> > It can be used to re-configure the link but also simple reset.
> >
> > Actually can we instead of the quirk in quirks.c add this to nhi.c and
> > "host_reset". So that on these AMD controllers trigger host reset in the
> > same way Windows would?
> >
> > That's DPR and probably host interface reset. In other words tie this to
> > the host reset we are doing for USB4 v2 routers (this one adds it for
> > USB4 v1 routers and enables it by default for AMD).
>
> Assuming this "works" how would you feel about just "aligning the behavior"
> with Windows for all USB4 routers instead of just these AMD controllers and
> USB4v2?

I was thinking the same pretty much after I wrote the reply ;-) Yeah, I
think it is worth a try.

It may need some additional code from Intel side to get the host fully
reset but I can do that myself on top.