Re: [PATCH v2 2/4] mm/ksm: add sysfs knobs for advisor

From: Stefan Roesch
Date: Wed Nov 22 2023 - 12:42:55 EST



David Hildenbrand <david@xxxxxxxxxx> writes:

> On 28.10.23 02:09, Stefan Roesch wrote:
>> This adds four new knobs for the KSM advisor to influence its behaviour.
>> The knobs are:
>> - advisor_mode:
>> 0: no advisor (default)
>> 1: scan time advisor
>> - advisor_min_cpu: 15 (default, cpu usage percent)
>> - advisor_max_cpu: 70 (default, cpu usage percent)
>> - advisor_min_pages: 500 (default)
>> - advisor_max_pages: 30000 (default)
>> - advisor_target_scan_time: 200 (default in seconds)
>
> Is there a way we can avoid exposing advisor_min_pages/advisor_max_pages and
> just have this internal e.g., as defines?
>
Yes, we can.