Re: [PATCH v5] zswap: memcontrol: implement zswap writeback disabling

[Chris Li]

On Tue, Nov 21, 2023 at 5:19 PM Nhat Pham <nphamcs@xxxxxxxxx> wrote:

> > "all": zswap + swapfile
> > "zswap": zswap only
> > "no_zswap": swapfile only.
> > "none": no swap.
> >
> > All keyword names are open to suggestions.
>
> SGTM! There might be some functionality duplication between
> memory.swap.tiers = no_zswap and memory.zswap.max = 0, but
> otherwise this seems reasonable to me.
>
> no_zswap sounds a bit awkward, but I can't come up with a better
> name.

I sleep on it a bit. I  should apply my own suggestion of using the
positive words rather than negative one to myself.
I actually define it as a non RAM base swap device. How about "disk"?
It will include SSD and HDD disk.

The current 4 combination will be:

"all": zswap + disk swap file
"zswap": zswap only
"disk": disk only (including SSD and HDD)
"none": no swap for you.

Chris