Re: [PATCH] ALSA: hda: cs35l56: Enable low-power hibernation mode on SPI

From: Richard Fitzgerald
Date: Wed Nov 22 2023 - 06:04:52 EST


On 21/11/23 20:36, Takashi Iwai wrote:
On Tue, 21 Nov 2023 16:44:19 +0100,
Richard Fitzgerald wrote:

SPI hibernation is now supported with the latest hibernation/wake
sequences in the shared ASoC code.

This has a functional dependency on two commits:

commit 3df761bdbc8b ("ASoC: cs35l56: Wake transactions need to be issued
twice")

commit a47cf4dac7dc ("ASoC: cs35l56: Change hibernate sequence to use
allow auto hibernate")

To protect against this, enabling hibernation is conditional on
CS35L56_WAKE_HOLD_TIME_US being defined, which indicates that the new
hibernation sequences are available.

Signed-off-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>

Is this expected to be merged for 6.7? Or it can be post 6.7?
I guess the former, but just to make sure.


It would be good to get it into 6.7 because it reduces the power
consumption in runtime-suspend and suspend-to-RAM. But it's not
critical (it's not a bugfix).


thanks,

Takashi