[PATCH] mm/slub: try to fix hangs without cmpxchg64/128
From: Vlastimil Babka
Date: Wed Nov 22 2023 - 04:32:41 EST
If we don't have cmpxchg64/128 and resort to slab_lock()/slab_unlock()
which uses PG_locked, we can get RMW with the newly introduced
slab_set/clear_node_partial() operation that modify PG_workingset so all
the operations have to be atomic now.
Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx>
---
mm/slub.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index bcb5b2c4e213..f2cdb81ab02e 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -522,7 +522,7 @@ static __always_inline void slab_unlock(struct slab *slab)
struct page *page = slab_page(slab);
VM_BUG_ON_PAGE(PageTail(page), page);
- __bit_spin_unlock(PG_locked, &page->flags);
+ bit_spin_unlock(PG_locked, &page->flags);
}
static inline bool
@@ -2127,12 +2127,12 @@ static inline bool slab_test_node_partial(const struct slab *slab)
static inline void slab_set_node_partial(struct slab *slab)
{
- __set_bit(PG_workingset, folio_flags(slab_folio(slab), 0));
+ set_bit(PG_workingset, folio_flags(slab_folio(slab), 0));
}
static inline void slab_clear_node_partial(struct slab *slab)
{
- __clear_bit(PG_workingset, folio_flags(slab_folio(slab), 0));
+ clear_bit(PG_workingset, folio_flags(slab_folio(slab), 0));
}
/*
--
2.42.1