Re: [PATCH 1/3] riscv: Add support for kernel-mode FPU

From: Christoph Hellwig
Date: Wed Nov 22 2023 - 03:33:40 EST


On Tue, Nov 21, 2023 at 07:05:13PM -0800, Samuel Holland wrote:
> +static inline void kernel_fpu_begin(void)
> +{
> + preempt_disable();
> + fstate_save(current, task_pt_regs(current));
> + csr_set(CSR_SSTATUS, SR_FS);
> +}
> +
> +static inline void kernel_fpu_end(void)
> +{
> + csr_clear(CSR_SSTATUS, SR_FS);
> + fstate_restore(current, task_pt_regs(current));
> + preempt_enable();
> +}

Is there any critical reason to inline these two? I'd much rather see
them out of line and exported instead of the low-level helpers.