RE: [PATCH net] net: axienet: Fix check for partial TX checksum

[Pandey, Radhey Shyam]

> -----Original Message-----
> From: Samuel Holland <samuel.holland@xxxxxxxxxx>
> Sent: Wednesday, November 22, 2023 6:12 AM
> To: Pandey, Radhey Shyam <radhey.shyam.pandey@xxxxxxx>
> Cc: Samuel Holland <samuel.holland@xxxxxxxxxx>; Ariane Keller
> <ariane.keller@xxxxxxxxxxxxxx>; Daniel Borkmann <daniel@xxxxxxxxxxxxx>;
> David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet
> <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Simek, Michal
> <michal.simek@xxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx
> Subject: [PATCH net] net: axienet: Fix check for partial TX checksum
> 
> Due to a typo, the code checked the RX checksum feature in the TX path.
> 
> Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet
> driver")
> Signed-off-by: Samuel Holland <samuel.holland@xxxxxxxxxx>

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxx>
Thanks!
> ---
> 
>  drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index 82d0d44b2b02..bf6e33990490 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -822,7 +822,7 @@ axienet_start_xmit(struct sk_buff *skb, struct
> net_device *ndev)
>  		if (lp->features & XAE_FEATURE_FULL_TX_CSUM) {
>  			/* Tx Full Checksum Offload Enabled */
>  			cur_p->app0 |= 2;
> -		} else if (lp->features & XAE_FEATURE_PARTIAL_RX_CSUM) {
> +		} else if (lp->features & XAE_FEATURE_PARTIAL_TX_CSUM) {
>  			csum_start_off = skb_transport_offset(skb);
>  			csum_index_off = csum_start_off + skb-
> >csum_offset;
>  			/* Tx Partial Checksum Offload Enabled */
> --
> 2.42.0