Re: [PATCH v1 2/2] net: stmmac: Add NPCM support
From: kernel test robot
Date: Tue Nov 21 2023 - 21:13:05 EST
Hi Tomer,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on net-next/main net/main linus/master v6.7-rc2 next-20231121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Tomer-Maimon/dt-bindings-net-Add-support-NPCM-dwmac/20231121-231908
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20231121151733.2015384-3-tmaimon77%40gmail.com
patch subject: [PATCH v1 2/2] net: stmmac: Add NPCM support
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20231122/202311221011.bsAmeQ6v-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231122/202311221011.bsAmeQ6v-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311221011.bsAmeQ6v-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/stmicro/stmmac/dwmac-npcm.c:53:6: warning: no previous prototype for function 'npcm_dwmac_pcs_init' [-Wmissing-prototypes]
void npcm_dwmac_pcs_init(struct npcm_dwmac *dwmac, struct device *dev,
^
drivers/net/ethernet/stmicro/stmmac/dwmac-npcm.c:53:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void npcm_dwmac_pcs_init(struct npcm_dwmac *dwmac, struct device *dev,
^
static
1 warning generated.
vim +/npcm_dwmac_pcs_init +53 drivers/net/ethernet/stmicro/stmmac/dwmac-npcm.c
52
> 53 void npcm_dwmac_pcs_init(struct npcm_dwmac *dwmac, struct device *dev,
54 struct plat_stmmacenet_data *plat_dat)
55 {
56 u16 val;
57
58 iowrite16((u16)(SR_MII_CTRL >> 9), dwmac->reg + IND_AC_BA_REG);
59 val = ioread16(dwmac->reg + PCS_SR_MII_CTRL_REG);
60 val |= PCS_RST;
61 iowrite16(val, dwmac->reg + PCS_SR_MII_CTRL_REG);
62
63 while (val & PCS_RST)
64 val = ioread16(dwmac->reg + PCS_SR_MII_CTRL_REG);
65
66 val &= ~(PCS_AN_ENABLE);
67 iowrite16(val, dwmac->reg + PCS_SR_MII_CTRL_REG);
68 }
69
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki