Re: [PATCH net-next v7 15/16] net: ethtool: ts: Let the active time stamping layer be selectable

From: Richard Cochran
Date: Tue Nov 21 2023 - 18:40:43 EST


On Tue, Nov 21, 2023 at 06:31:14PM +0100, Köry Maincent wrote:
> If I summarize, a solution could be this:
>
> - Expand struct hwtstamp_config with a phc_index member for the SIOCG/SHWTSTAMP
> commands.
> To keep backward compatibility if phc_index is not set in the hwtstamp_config
> data from userspace use the default hwtstamp (the default being selected as
> done in my patch series).
> Is this possible, would it breaks things?

You can't "expand" hwtstamp_config because it is an established ABI.

(You could introduce SIOC[GS]HWTSTAMP_2 with an expanded layout)

Thanks,
Richard