Re: [PATCH v17 020/116] KVM: TDX: create/destroy VM structure

From: Isaku Yamahata
Date: Tue Nov 21 2023 - 14:16:08 EST


On Sun, Nov 19, 2023 at 02:30:19PM +0800,
Binbin Wu <binbin.wu@xxxxxxxxxxxxxxx> wrote:

> > +static int tdx_reclaim_page(hpa_t pa)
> > +{
> > + int r;
> > +
> > + r = __tdx_reclaim_page(pa);
> > + if (!r)
> > + tdx_clear_page(pa);
> > + return r;
> > +}
> > +
> > +static void tdx_reclaim_td_page(unsigned long td_page_pa)
>
> This function is used to reclaim td control sturcture pages like TDCX,
> TDVPX,
> TDVPR. Should this function name be more specific?
> For me, it is a bit confusing.
>
> Or maybe do "td page" have specific meaning referring to these control
> structures
> pages in TDX?

As they are control page, how about tdx_reclaim_control_page()?
--
Isaku Yamahata <isaku.yamahata@xxxxxxxxxxxxxxx>