Re: [PATCH 3/3] perf bench sched-seccomp-notify: Fix __NR_seccomp undeclared build error on i386

From: Namhyung Kim
Date: Tue Nov 21 2023 - 13:57:33 EST


Hello,

On Fri, Nov 17, 2023 at 6:51 PM Yang Jihong <yangjihong1@xxxxxxxxxx> wrote:
>
> Fix a build error on i386 system:
>
> bench/sched-seccomp-notify.c: In function 'seccomp':
> bench/sched-seccomp-notify.c:46:17: error: '__NR_seccomp' undeclared (first use in this function); did you mean 'seccomp'?
> return syscall(__NR_seccomp, op, flags, args);
> ^~~~~~~~~~~~
> seccomp
> bench/sched-seccomp-notify.c:46:17: note: each undeclared identifier is reported only once for each function it appears in
> bench/sched-seccomp-notify.c:47:1: error: control reaches end of non-void function [-Werror=return-type]
> }
> ^
> cc1: all warnings being treated as errors
>
> Fixes: 7d5cb68af638 ("perf/benchmark: add a new benchmark for seccom_unotify")
> Signed-off-by: Yang Jihong <yangjihong1@xxxxxxxxxx>

This is already fixed by:
https://lore.kernel.org/all/20231017083019.31733-1-jirislaby@xxxxxxxxxx/

Thanks,
Namhyung


> ---
> tools/arch/x86/include/uapi/asm/unistd_32.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/arch/x86/include/uapi/asm/unistd_32.h b/tools/arch/x86/include/uapi/asm/unistd_32.h
> index 4798f9d18fe8..9de35df1afc3 100644
> --- a/tools/arch/x86/include/uapi/asm/unistd_32.h
> +++ b/tools/arch/x86/include/uapi/asm/unistd_32.h
> @@ -26,6 +26,6 @@
> #ifndef __NR_setns
> #define __NR_setns 346
> #endif
> -#ifdef __NR_seccomp
> +#ifndef __NR_seccomp
> #define __NR_seccomp 354
> #endif
> --
> 2.34.1
>