Re: [PATCH v3] perf vendor events riscv: add StarFive Dubhe-90 JSON file

From: Ian Rogers
Date: Tue Nov 21 2023 - 10:38:45 EST

Next message: Johan Hovold: "Re: [PATCH v4 3/3] arm64: dts: qcom: sa8775p: Mark PCIe EP controller as cache coherent"
Previous message: Thorsten Leemhuis: "Re: Fwd: dwc3: regression in USB DWC3 driver in kernel 5.15 branch"
Next in thread: Ji Sheng Teoh: "Re: [PATCH v3] perf vendor events riscv: add StarFive Dubhe-90 JSON file"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, Nov 8, 2023 at 11:51 PM Ji Sheng Teoh
<jisheng.teoh@xxxxxxxxxxxxxxxx> wrote:
>
> StarFive's Dubhe-90 supports raw event id 0x00 - 0x22.
> The raw events are enabled through PMU node of DT binding.
> Besides raw event, add standard RISC-V firmware events to
> support monitoring of firmware event.
>
> Example of PMU DT node:
> pmu {
> compatible = "riscv,pmu";
> riscv,raw-event-to-mhpmcounters =
> /* Event ID 1-31 */
> <0x00 0x00 0xFFFFFFFF 0xFFFFFFE0 0x00007FF8>,
> /* Event ID 32-33 */
> <0x00 0x20 0xFFFFFFFF 0xFFFFFFFE 0x00007FF8>,
> /* Event ID 34 */
> <0x00 0x22 0xFFFFFFFF 0xFFFFFF22 0x00007FF8>;
> };
>
> Perf stat output:
> [root@user]# perf stat -a \
> -e access_mmu_stlb \
> -e miss_mmu_stlb \
> -e access_mmu_pte_c \
> -e rob_flush \
> -e btb_prediction_miss \
> -e itlb_miss \
> -e sync_del_fetch_g \
> -e icache_miss \
> -e bpu_br_retire \
> -e bpu_br_miss \
> -e ret_ins_retire \
> -e ret_ins_miss \
> -- openssl speed rsa2048
> Doing 2048 bits private rsa's for 10s: 39 2048 bits private RSA's in
> 10.03s
> Doing 2048 bits public rsa's for 10s: 1469 2048 bits public RSA's in
> 9.47s
> version: 3.0.10
> built on: Tue Aug 1 13:47:24 2023 UTC
> options: bn(64,64)
> CPUINFO: N/A
> sign verify sign/s verify/s
> rsa 2048 bits 0.257179s 0.006447s 3.9 155.1
>
> Performance counter stats for 'system wide':
>
> 3112882 access_mmu_stlb
> 10550 miss_mmu_stlb
> 18251 access_mmu_pte_c
> 274765 rob_flush
> 22470560 btb_prediction_miss
> 3035839 itlb_miss
> 643549060 sync_del_fetch_g
> 133013 icache_miss
> 62982796 bpu_br_retire
> 287548 bpu_br_miss
> 8935910 ret_ins_retire
> 8308 ret_ins_miss
>
> 20.656182600 seconds time elapsed
>
> Signed-off-by: Ji Sheng Teoh <jisheng.teoh@xxxxxxxxxxxxxxxx>
> Reviewed-by: Ley Foon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>
> ---
> Changelog:
> v2 -> v3:
> - Add standard RISC-V firmware event
> - Update commit message to reflect addition of standard
> RISC-V firmware event.
> v1 -> v2:
> - Rename 'Starfive Dubhe' to 'StarFive Dubhe-90' in commit message.
> - Rename 'starfive/dubhe' pmu-events folder to 'starfive/dubhe-90'
> - Update MARCHID to 0x80000000db000090 in mapfile.csv
> ---
> tools/perf/pmu-events/arch/riscv/mapfile.csv | 1 +
> .../arch/riscv/starfive/dubhe-90/common.json | 172 ++++++++++++++++++
> .../riscv/starfive/dubhe-90/firmware.json | 68 +++++++
> 3 files changed, 241 insertions(+)
> create mode 100644 tools/perf/pmu-events/arch/riscv/starfive/dubhe-90/common.json
> create mode 100644 tools/perf/pmu-events/arch/riscv/starfive/dubhe-90/firmware.json
>
> diff --git a/tools/perf/pmu-events/arch/riscv/mapfile.csv b/tools/perf/pmu-events/arch/riscv/mapfile.csv
> index c61b3d6ef616..5b75ecfe206d 100644
> --- a/tools/perf/pmu-events/arch/riscv/mapfile.csv
> +++ b/tools/perf/pmu-events/arch/riscv/mapfile.csv
> @@ -15,3 +15,4 @@
> #
> #MVENDORID-MARCHID-MIMPID,Version,Filename,EventType
> 0x489-0x8000000000000007-0x[[:xdigit:]]+,v1,sifive/u74,core
> +0x67e-0x80000000db000090-0x[[:xdigit:]]+,v1,starfive/dubhe-90,core

I've no problem with this approach, but dubhe-90's json files match
dubhe-80s. Those files are available in perf-tools-next:
https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/pmu-events/arch/riscv/starfive/dubhe-80?h=perf-tools-next
It could be useful to rebase the patch on that branch to make it
easier to merge. As the files match you could make the regular
expression for dubhe-80 match both of them like:

0x67e-0x80000000db0000[89]0-0x[[:xdigit:]]+,v1,starfive/dubhe-80,core

Thanks,
Ian

> \ No newline at end of file
> diff --git a/tools/perf/pmu-events/arch/riscv/starfive/dubhe-90/common.json b/tools/perf/pmu-events/arch/riscv/starfive/dubhe-90/common.json
> new file mode 100644
> index 000000000000..fbffcacb2ace
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/riscv/starfive/dubhe-90/common.json
> @@ -0,0 +1,172 @@
> +[
> + {
> + "EventName": "ACCESS_MMU_STLB",
> + "EventCode": "0x1",
> + "BriefDescription": "access MMU STLB"
> + },
> + {
> + "EventName": "MISS_MMU_STLB",
> + "EventCode": "0x2",
> + "BriefDescription": "miss MMU STLB"
> + },
> + {
> + "EventName": "ACCESS_MMU_PTE_C",
> + "EventCode": "0x3",
> + "BriefDescription": "access MMU PTE-Cache"
> + },
> + {
> + "EventName": "MISS_MMU_PTE_C",
> + "EventCode": "0x4",
> + "BriefDescription": "miss MMU PTE-Cache"
> + },
> + {
> + "EventName": "ROB_FLUSH",
> + "EventCode": "0x5",
> + "BriefDescription": "ROB flush (all kinds of exceptions)"
> + },
> + {
> + "EventName": "BTB_PREDICTION_MISS",
> + "EventCode": "0x6",
> + "BriefDescription": "BTB prediction miss"
> + },
> + {
> + "EventName": "ITLB_MISS",
> + "EventCode": "0x7",
> + "BriefDescription": "ITLB miss"
> + },
> + {
> + "EventName": "SYNC_DEL_FETCH_G",
> + "EventCode": "0x8",
> + "BriefDescription": "SYNC delivery a fetch-group"
> + },
> + {
> + "EventName": "ICACHE_MISS",
> + "EventCode": "0x9",
> + "BriefDescription": "ICache miss"
> + },
> + {
> + "EventName": "BPU_BR_RETIRE",
> + "EventCode": "0xA",
> + "BriefDescription": "condition branch instruction retire"
> + },
> + {
> + "EventName": "BPU_BR_MISS",
> + "EventCode": "0xB",
> + "BriefDescription": "condition branch instruction miss"
> + },
> + {
> + "EventName": "RET_INS_RETIRE",
> + "EventCode": "0xC",
> + "BriefDescription": "return instruction retire"
> + },
> + {
> + "EventName": "RET_INS_MISS",
> + "EventCode": "0xD",
> + "BriefDescription": "return instruction miss"
> + },
> + {
> + "EventName": "INDIRECT_JR_MISS",
> + "EventCode": "0xE",
> + "BriefDescription": "indirect JR instruction miss (inlcude without target)"
> + },
> + {
> + "EventName": "IBUF_VAL_ID_NORDY",
> + "EventCode": "0xF",
> + "BriefDescription": "IBUF valid while ID not ready"
> + },
> + {
> + "EventName": "IBUF_NOVAL_ID_RDY",
> + "EventCode": "0x10",
> + "BriefDescription": "IBUF not valid while ID ready"
> + },
> + {
> + "EventName": "REN_INT_PHY_REG_NORDY",
> + "EventCode": "0x11",
> + "BriefDescription": "REN integer physical register file is not ready"
> + },
> + {
> + "EventName": "REN_FP_PHY_REG_NORDY",
> + "EventCode": "0x12",
> + "BriefDescription": "REN floating point physical register file is not ready"
> + },
> + {
> + "EventName": "REN_CP_NORDY",
> + "EventCode": "0x13",
> + "BriefDescription": "REN checkpoint is not ready"
> + },
> + {
> + "EventName": "DEC_VAL_ROB_NORDY",
> + "EventCode": "0x14",
> + "BriefDescription": "DEC is valid and ROB is not ready"
> + },
> + {
> + "EventName": "OOD_FLUSH_LS_DEP",
> + "EventCode": "0x15",
> + "BriefDescription": "out of order flush due to load/store dependency"
> + },
> + {
> + "EventName": "BRU_RET_IJR_INS",
> + "EventCode": "0x16",
> + "BriefDescription": "BRU retire an IJR instruction"
> + },
> + {
> + "EventName": "ACCESS_DTLB",
> + "EventCode": "0x17",
> + "BriefDescription": "access DTLB"
> + },
> + {
> + "EventName": "MISS_DTLB",
> + "EventCode": "0x18",
> + "BriefDescription": "miss DTLB"
> + },
> + {
> + "EventName": "LOAD_INS_DCACHE",
> + "EventCode": "0x19",
> + "BriefDescription": "load instruction access DCache"
> + },
> + {
> + "EventName": "LOAD_INS_MISS_DCACHE",
> + "EventCode": "0x1A",
> + "BriefDescription": "load instruction miss DCache"
> + },
> + {
> + "EventName": "STORE_INS_DCACHE",
> + "EventCode": "0x1B",
> + "BriefDescription": "store/amo instruction access DCache"
> + },
> + {
> + "EventName": "STORE_INS_MISS_DCACHE",
> + "EventCode": "0x1C",
> + "BriefDescription": "store/amo instruction miss DCache"
> + },
> + {
> + "EventName": "LOAD_SCACHE",
> + "EventCode": "0x1D",
> + "BriefDescription": "load access SCache"
> + },
> + {
> + "EventName": "STORE_SCACHE",
> + "EventCode": "0x1E",
> + "BriefDescription": "store access SCache"
> + },
> + {
> + "EventName": "LOAD_MISS_SCACHE",
> + "EventCode": "0x1F",
> + "BriefDescription": "load miss SCache"
> + },
> + {
> + "EventName": "STORE_MISS_SCACHE",
> + "EventCode": "0x20",
> + "BriefDescription": "store miss SCache"
> + },
> + {
> + "EventName": "L2C_PF_REQ",
> + "EventCode": "0x21",
> + "BriefDescription": "L2C data-prefetcher request"
> + },
> + {
> + "EventName": "L2C_PF_HIT",
> + "EventCode": "0x22",
> + "BriefDescription": "L2C data-prefetcher hit"
> + }
> +]
> diff --git a/tools/perf/pmu-events/arch/riscv/starfive/dubhe-90/firmware.json b/tools/perf/pmu-events/arch/riscv/starfive/dubhe-90/firmware.json
> new file mode 100644
> index 000000000000..9b4a032186a7
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/riscv/starfive/dubhe-90/firmware.json
> @@ -0,0 +1,68 @@
> +[
> + {
> + "ArchStdEvent": "FW_MISALIGNED_LOAD"
> + },
> + {
> + "ArchStdEvent": "FW_MISALIGNED_STORE"
> + },
> + {
> + "ArchStdEvent": "FW_ACCESS_LOAD"
> + },
> + {
> + "ArchStdEvent": "FW_ACCESS_STORE"
> + },
> + {
> + "ArchStdEvent": "FW_ILLEGAL_INSN"
> + },
> + {
> + "ArchStdEvent": "FW_SET_TIMER"
> + },
> + {
> + "ArchStdEvent": "FW_IPI_SENT"
> + },
> + {
> + "ArchStdEvent": "FW_IPI_RECEIVED"
> + },
> + {
> + "ArchStdEvent": "FW_FENCE_I_SENT"
> + },
> + {
> + "ArchStdEvent": "FW_FENCE_I_RECEIVED"
> + },
> + {
> + "ArchStdEvent": "FW_SFENCE_VMA_SENT"
> + },
> + {
> + "ArchStdEvent": "FW_SFENCE_VMA_RECEIVED"
> + },
> + {
> + "ArchStdEvent": "FW_SFENCE_VMA_RECEIVED"
> + },
> + {
> + "ArchStdEvent": "FW_SFENCE_VMA_ASID_RECEIVED"
> + },
> + {
> + "ArchStdEvent": "FW_HFENCE_GVMA_SENT"
> + },
> + {
> + "ArchStdEvent": "FW_HFENCE_GVMA_RECEIVED"
> + },
> + {
> + "ArchStdEvent": "FW_HFENCE_GVMA_VMID_SENT"
> + },
> + {
> + "ArchStdEvent": "FW_HFENCE_GVMA_VMID_RECEIVED"
> + },
> + {
> + "ArchStdEvent": "FW_HFENCE_VVMA_SENT"
> + },
> + {
> + "ArchStdEvent": "FW_HFENCE_VVMA_RECEIVED"
> + },
> + {
> + "ArchStdEvent": "FW_HFENCE_VVMA_ASID_SENT"
> + },
> + {
> + "ArchStdEvent": "FW_HFENCE_VVMA_ASID_RECEIVED"
> + }
> +]
> --
> 2.25.1
>

Next message: Johan Hovold: "Re: [PATCH v4 3/3] arm64: dts: qcom: sa8775p: Mark PCIe EP controller as cache coherent"
Previous message: Thorsten Leemhuis: "Re: Fwd: dwc3: regression in USB DWC3 driver in kernel 5.15 branch"
Next in thread: Ji Sheng Teoh: "Re: [PATCH v3] perf vendor events riscv: add StarFive Dubhe-90 JSON file"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]