arch/um/drivers/pcap_kern.c:18:6: sparse: sparse: symbol 'pcap_init_kern' was not declared. Should it be static?

From: kernel test robot
Date: Tue Nov 21 2023 - 08:39:00 EST


tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 98b1cc82c4affc16f5598d4fa14b1858671b2263
commit: 2c4d3841a82b88ae8a7b518dc6206f84f68e705a um: Avoid pcap multiple definition errors
date: 9 months ago
config: um-randconfig-r133-20231121 (https://download.01.org/0day-ci/archive/20231121/202311212152.kqZWYPEr-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231121/202311212152.kqZWYPEr-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311212152.kqZWYPEr-lkp@xxxxxxxxx/

sparse warnings: (new ones prefixed by >>)
>> arch/um/drivers/pcap_kern.c:18:6: sparse: sparse: symbol 'pcap_init_kern' was not declared. Should it be static?
arch/um/drivers/pcap_kern.c:53:5: sparse: sparse: symbol 'pcap_setup' was not declared. Should it be static?

vim +/pcap_init_kern +18 arch/um/drivers/pcap_kern.c

17
> 18 void pcap_init_kern(struct net_device *dev, void *data)
19 {
20 struct uml_net_private *pri;
21 struct pcap_data *ppri;
22 struct pcap_init *init = data;
23
24 pri = netdev_priv(dev);
25 ppri = (struct pcap_data *) pri->user;
26 ppri->host_if = init->host_if;
27 ppri->promisc = init->promisc;
28 ppri->optimize = init->optimize;
29 ppri->filter = init->filter;
30
31 printk("pcap backend, host interface %s\n", ppri->host_if);
32 }
33

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki