Re: [PATCH] drm/bridge: imx93-mipi-dsi: Fix a couple of building warnings

[Maxime Ripard]

On Tue, Nov 21, 2023 at 04:56:44PM +0800, Liu Ying wrote:
> Fix a couple of building warnings on used uninitialized 'best_m' and
> 'best_n' local variables by initializing them to zero.  This makes compiler
> happy only.  No functional change.
> 
> Fixes: ce62f8ea7e3f ("drm/bridge: imx: Add i.MX93 MIPI DSI support")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202311151746.f7u7dzbZ-lkp@xxxxxxxxx/
> Signed-off-by: Liu Ying <victor.liu@xxxxxxx>
> ---
>  drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c b/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c
> index 3ff30ce80c5b..7b3b4f985098 100644
> --- a/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c
> @@ -226,8 +226,8 @@ dphy_pll_get_configure_from_opts(struct imx93_dsi *dsi,
>  	unsigned long fout;
>  	unsigned long best_fout = 0;
>  	unsigned int fvco_div;
> -	unsigned int min_n, max_n, n, best_n;
> -	unsigned long m, best_m;
> +	unsigned int min_n, max_n, n, best_n = 0;
> +	unsigned long m, best_m = 0;
>  	unsigned long min_delta = ULONG_MAX;
>  	unsigned long delta;
>  	u64 tmp;

N is a divider, so it would probably be better to initialize it to
UINT_MAX to avoid any divide-by-0 error.

Maxime

Attachment: signature.asc
Description: PGP signature