Re: [PATCH v6 0/6] Fix support of dw-edma HDMA NATIVE IP in remote setup

From: Manivannan Sadhasivam
Date: Tue Nov 21 2023 - 01:33:13 EST


On Fri, Nov 17, 2023 at 11:03:48AM +0100, Kory Maincent wrote:
> This patch series fix the support of dw-edma HDMA NATIVE IP.
> I can only test it in remote HDMA IP setup with single dma transfer, but
> with these fixes it works properly.
>
> Few fixes has also been added for eDMA version. Similarly to HDMA I have
> tested only eDMA in remote setup.
>

Just out of curiosity, can you share how you are setting EDMA_MF_HDMA_NATIVE?

- Mani

> Changes in v2:
> - Update comments and fix typos.
> - Removed patches that tackle hypothetical bug and then were not pertinent.
> - Add the similar HDMA race condition in remote setup fix to eDMA IP driver.
>
> Changes in v3:
> - Fix comment style.
> - Split a patch in two to differ bug fix and simple harmless typo.
>
> Changes in v4:
> - Update patch git commit message.
> - Link to v3: https://lore.kernel.org/r/20231011-b4-feature_hdma_mainline-v3-0-24ee0c979c6f@xxxxxxxxxxx
>
> Changes in v5:
> - No change
> - Rebase to mainline 6.7-rc1
> - Link to v4: https://lore.kernel.org/r/20231011-b4-feature_hdma_mainline-v4-0-43d417b93138@xxxxxxxxxxx
>
> Changes in v6:
> - Fix several commit messages and comments.
> - Link to v5: https://lore.kernel.org/r/20231114-b4-feature_hdma_mainline-v5-0-7bc86d83c6f7@xxxxxxxxxxx
>
> Signed-off-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>
> ---
> Kory Maincent (6):
> dmaengine: dw-edma: Fix the ch_count hdma callback
> dmaengine: dw-edma: Fix wrong interrupt bit set for HDMA
> dmaengine: dw-edma: HDMA_V0_REMOTEL_STOP_INT_EN typo fix
> dmaengine: dw-edma: Add HDMA remote interrupt configuration
> dmaengine: dw-edma: HDMA: Add sync read before starting the DMA transfer in remote setup
> dmaengine: dw-edma: eDMA: Add sync read before starting the DMA transfer in remote setup
>
> drivers/dma/dw-edma/dw-edma-v0-core.c | 17 +++++++++++++++
> drivers/dma/dw-edma/dw-hdma-v0-core.c | 39 +++++++++++++++++++++++------------
> drivers/dma/dw-edma/dw-hdma-v0-regs.h | 2 +-
> 3 files changed, 44 insertions(+), 14 deletions(-)
> ---
> base-commit: b85ea95d086471afb4ad062012a4d73cd328fa86
> change-id: 20231011-b4-feature_hdma_mainline-b6c57f8e3b5d
>
> Best regards,
> --
> Köry Maincent, Bootlin
> Embedded Linux and kernel engineering
> https://bootlin.com
>

--
மணிவண்ணன் சதாசிவம்