Re: [PATCH] nbd: pass nbd_sock to nbd_read_reply() instead of index

[Li Nan]

Hi, Jens

This patch has been reviewed by Yu Kuai and Ming Lei. Could you please
consider apply it?

在 2023/10/30 21:16, Yu Kuai 写道:
> 在 2023/10/30 20:42, Ming Lei 写道:
>
> > > After reviewing some code, I found that it's wrong to grab config_lock,
> > > because other context will grab such lock and flush_workqueue(), and
> > > there is no gurantee that recv_work() will grab the lock first.
> > >
> > > Will it be acceptable to export blk_queue_enter()? I can't think of
> > > other way to retrieve the`nsock` reference at the entry of recv_work().
> >
> > Then I think it is easier to pass `nsock` from `recv_thread_args`, which
> > can be thought as local variable too.
> >
> > Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx>
>
> Agreed
>
> Reviewed-by: Yu Kuai <yukuai3@xxxxxxxxxx>
>
> .

--
Thanks,
Nan