[PATCH] selftests/media_tests: fix a resource leak

From: zhujun2
Date: Mon Nov 20 2023 - 21:59:31 EST


The opened file should be closed in main(), otherwise resource
leak will occur that this problem was discovered by code reading

Signed-off-by: zhujun2 <zhujun2@xxxxxxxxxxxxxxxxxxxx>
---
tools/testing/selftests/media_tests/media_device_open.c | 3 +++
tools/testing/selftests/media_tests/media_device_test.c | 3 +++
2 files changed, 6 insertions(+)

diff --git a/tools/testing/selftests/media_tests/media_device_open.c b/tools/testing/selftests/media_tests/media_device_open.c
index 93183a37b133..2dfb2a11b148 100644
--- a/tools/testing/selftests/media_tests/media_device_open.c
+++ b/tools/testing/selftests/media_tests/media_device_open.c
@@ -70,6 +70,7 @@ int main(int argc, char **argv)
fd = open(media_device, O_RDWR);
if (fd == -1) {
printf("Media Device open errno %s\n", strerror(errno));
+ close(fd);
exit(-1);
}

@@ -79,4 +80,6 @@ int main(int argc, char **argv)
else
printf("Media device model %s driver %s\n",
mdi.model, mdi.driver);
+
+ close(fd);
}
diff --git a/tools/testing/selftests/media_tests/media_device_test.c b/tools/testing/selftests/media_tests/media_device_test.c
index 4b9953359e40..7cabb62535a7 100644
--- a/tools/testing/selftests/media_tests/media_device_test.c
+++ b/tools/testing/selftests/media_tests/media_device_test.c
@@ -79,6 +79,7 @@ int main(int argc, char **argv)
fd = open(media_device, O_RDWR);
if (fd == -1) {
printf("Media Device open errno %s\n", strerror(errno));
+ close(fd);
exit(-1);
}

@@ -100,4 +101,6 @@ int main(int argc, char **argv)
sleep(10);
count--;
}
+
+ close(fd);
}
--
2.17.1