Re: [PATCH 10/16] arm64: dts: qcom: sm8550-aim300: add display and panel

[Tengfei Fan]

在 11/17/2023 6:30 PM, Dmitry Baryshkov 写道:
> On 17/11/2023 12:18, Tengfei Fan wrote:
> > Enable Display Subsystem with Visionox VTDR6130 Panel.
> >
> > Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/sm8550-aim300.dts | 68 ++++++++++++++++++++++
> >   1 file changed, 68 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8550-aim300.dts 
> > b/arch/arm64/boot/dts/qcom/sm8550-aim300.dts
> > index cafddc02aef0..9b568ae9581e 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8550-aim300.dts
> > +++ b/arch/arm64/boot/dts/qcom/sm8550-aim300.dts
> > @@ -432,6 +432,46 @@
> >            <&usb_dp_qmpphy QMP_USB43DP_USB3_PIPE_CLK>;
> >   };
> > +&mdss {
> > +    status = "okay";
> > +};
> > +
> > +&mdss_dsi0 {
> > +    vdda-supply = <&vreg_l3e_1p2>;
> > +    status = "okay";
> > +
> > +    panel@0 {
> > +        compatible = "visionox,vtdr6130";
> > +        reg = <0>;
> > +
> > +        pinctrl-0 = <&sde_dsi_active>, <&sde_te_active>;
> > +        pinctrl-1 = <&sde_dsi_suspend>, <&sde_te_suspend>;
> > +        pinctrl-names = "default", "sleep";
> > +
> > +        reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
> > +
> > +        vci-supply = <&vreg_l13b_3p0>;
> > +        vdd-supply = <&vreg_l11b_1p2>;
> > +        vddio-supply = <&vreg_l12b_1p8>;
> > +
> > +        port {
> > +            panel0_in: endpoint {
> > +                remote-endpoint = <&mdss_dsi0_out>;
> > +            };
> > +        };
> > +    };
> > +};
> > +
> > +&mdss_dsi0_out {
> > +    remote-endpoint = <&panel0_in>;
> > +    data-lanes = <0 1 2 3>;
> > +};
> > +
> > +&mdss_dsi0_phy {
> > +    vdds-supply = <&vreg_l1e_0p88>;
> > +    status = "okay";
> > +};
> > +
> >   &pcie_1_phy_aux_clk {
> >       status = "disabled";
> >   };
> > @@ -533,6 +573,34 @@
> >   &tlmm {
> >       gpio-reserved-ranges = <32 8>;
> > +    sde_dsi_active: sde-dsi-active-state {
>
> sde is the name from the other kernel branch. Drop it please. Just 'dsi' 
> is enough.
sure, I wil drop sde in next new version patch series.
> > +        pins = "gpio133";
> > +        function = "gpio";
> > +        drive-strength = <8>;
> > +        bias-disable;
> > +    };
> > +
> > +    sde_dsi_suspend: sde-dsi-suspend-state {
> > +        pins = "gpio133";
> > +        function = "gpio";
> > +        drive-strength = <2>;
> > +        bias-pull-down;
> > +    };
> > +
> > +    sde_te_active: sde-te-active-state {
> > +        pins = "gpio86";
> > +        function = "mdp_vsync";
> > +        drive-strength = <2>;
> > +        bias-pull-down;
> > +    };
> > +
> > +    sde_te_suspend: sde-te-suspend-state {
> > +        pins = "gpio86";
> > +        function = "mdp_vsync";
> > +        drive-strength = <2>;
> > +        bias-pull-down;
> > +    };
> > +
> >       wcd_default: wcd-reset-n-active-state {
> >           pins = "gpio108";
> >           function = "gpio";

--
Thx and BRs,
Tengfei Fan