Re: [PATCH 06/16] arm64: dts: qcom: sm8550-aim300: add SM8550 AIM300

[Tengfei Fan]

在 11/17/2023 6:28 PM, Dmitry Baryshkov 写道:
> On 17/11/2023 12:18, Tengfei Fan wrote:
> > Add a minimal DTS for the new QRD8550 board, serial, UFS and USB should
> > be working.
>
> An explanation of what is AIM300 would be welcomed.
>
> > Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/Makefile          |   1 +
> >   arch/arm64/boot/dts/qcom/sm8550-aim300.dts | 490 +++++++++++++++++++++
> >   2 files changed, 491 insertions(+)
> >   create mode 100644 arch/arm64/boot/dts/qcom/sm8550-aim300.dts
> >
> > diff --git a/arch/arm64/boot/dts/qcom/Makefile 
> > b/arch/arm64/boot/dts/qcom/Makefile
> > index d6cb840b7050..ea5d4a07671a 100644
> > --- a/arch/arm64/boot/dts/qcom/Makefile
> > +++ b/arch/arm64/boot/dts/qcom/Makefile
> > @@ -229,5 +229,6 @@ dtb-$(CONFIG_ARCH_QCOM)    += sm8450-hdk.dtb
> >   dtb-$(CONFIG_ARCH_QCOM)    += sm8450-qrd.dtb
> >   dtb-$(CONFIG_ARCH_QCOM)    += sm8450-sony-xperia-nagara-pdx223.dtb
> >   dtb-$(CONFIG_ARCH_QCOM)    += sm8450-sony-xperia-nagara-pdx224.dtb
> > +dtb-$(CONFIG_ARCH_QCOM) += sm8550-aim300.dtb
>
> My email client suggests that alignment is broken here.
I checked the code after apply this patch, and find this code alignment 
have not issue, so I will check if have some format issue when I do this 
patch.
> >   dtb-$(CONFIG_ARCH_QCOM)    += sm8550-mtp.dtb
> >   dtb-$(CONFIG_ARCH_QCOM)    += sm8550-qrd.dtb
> > diff --git a/arch/arm64/boot/dts/qcom/sm8550-aim300.dts 
> > b/arch/arm64/boot/dts/qcom/sm8550-aim300.dts
> > new file mode 100644
> > index 000000000000..202b979da8ca
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/sm8550-aim300.dts
> > @@ -0,0 +1,490 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +/*
> > + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights 
> > reserved.
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> > +#include "sm8550.dtsi"
> > +#include "pm8010.dtsi"
> > +#include "pm8550.dtsi"
> > +#include "pm8550b.dtsi"
> > +#include "pm8550ve.dtsi"
> > +#include "pm8550vs.dtsi"
> > +#include "pmk8550.dtsi"
> > +#include "pmr735d_a.dtsi"
> > +#include "pmr735d_b.dtsi"
> > +
> > +/ {
> > +    model = "Qualcomm Technologies, Inc. SM8550 AIM300";
> > +    compatible = "qcom,sm8550-aim300", "qcom,sm8550";
> > +
> > +    aliases {
> > +        serial0 = &uart7;
> > +    };
> > +
> > +    chosen {
> > +        stdout-path = "serial0:115200n8";
> > +    };
> > +
> > +    pmic-glink {
> > +        compatible = "qcom,sm8550-pmic-glink", "qcom,pmic-glink";
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +        orientation-gpios = <&tlmm 11 GPIO_ACTIVE_HIGH>;
> > +
> > +        connector@0 {
> > +            compatible = "usb-c-connector";
> > +            reg = <0>;
> > +            power-role = "dual";
> > +            data-role = "dual";
> > +
> > +            ports {
> > +                #address-cells = <1>;
> > +                #size-cells = <0>;
> > +
> > +                port@0 {
> > +                    reg = <0>;
> > +
> > +                    pmic_glink_hs_in: endpoint {
> > +                        remote-endpoint = <&usb_1_dwc3_hs>;
> > +                    };
> > +                };
> > +
> > +                port@1 {
> > +                    reg = <1>;
> > +
> > +                    pmic_glink_ss_in: endpoint {
> > +                        remote-endpoint = <&usb_1_dwc3_ss>;
> > +                    };
> > +                };
> > +            };
> > +        };
> > +    };
> > +
> > +    vph_pwr: vph-pwr-regulator {
>
> It's not demanded, I think, but I'd suggest 'regulator-vph-pwr' to allow 
> all regulators to be grouped together.
Thanks this comments, I will sync your comments with internal team, then 
I will update sync result to you.
> > +        compatible = "regulator-fixed";
> > +        regulator-name = "vph_pwr";
> > +        regulator-min-microvolt = <3700000>;
> > +        regulator-max-microvolt = <3700000>;
> > +
> > +        regulator-always-on;
> > +        regulator-boot-on;
> > +    };
> > +};
>
> Other than that looks good to me.

--
Thx and BRs,
Tengfei Fan