Re: [PATCH] perf script perl: Fail check on dynamic allocation

[Ian Rogers]

On Mon, Nov 20, 2023 at 3:24 AM zhaimingbing
<zhaimingbing@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> Return ENOMEM when dynamic allocation failed.
>
> Signed-off-by: zhaimingbing <zhaimingbing@xxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks,
Ian

> ---
>  tools/perf/util/scripting-engines/trace-event-perl.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/tools/perf/util/scripting-engines/trace-event-perl.c b/tools/perf/util/scripting-engines/trace-event-perl.c
> index 603091317..b072ac5d3 100644
> --- a/tools/perf/util/scripting-engines/trace-event-perl.c
> +++ b/tools/perf/util/scripting-engines/trace-event-perl.c
> @@ -490,6 +490,9 @@ static int perl_start_script(const char *script, int argc, const char **argv,
>         scripting_context->session = session;
>
>         command_line = malloc((argc + 2) * sizeof(const char *));
> +       if (!command_line)
> +               return -ENOMEM;
> +
>         command_line[0] = "";
>         command_line[1] = script;
>         for (i = 2; i < argc + 2; i++)
> --
> 2.33.0
>
>
>
>