Re: [PATCH v4 2/2] ASoC: imx-rpmsg: Force codec power on in low power audio mode

From: Mark Brown
Date: Mon Nov 20 2023 - 17:07:26 EST


On Mon, Oct 23, 2023 at 10:07:18AM +0800, Chancel Liu wrote:
> Low power audio mode requires binding codec still power on while Acore
> enters into suspend so Mcore can continue playback music.
>
> ASoC machine driver acquires DAPM endpoints through reading
> "ignore-suspend-widgets" property from DT and then forces the path
> between these endpoints ignoring suspend.

This breaks an x86 allmodconfig build:

/build/stage/linux/sound/soc/fsl/imx-rpmsg.c: In function ‘imx_rpmsg_late_probe’
:
/build/stage/linux/sound/soc/fsl/imx-rpmsg.c:60:46: error: implicit declaration
of function ‘of_find_device_by_node’; did you mean ‘of_find_i2c_device_by_node’?
[-Werror=implicit-function-declaration]
60 | codec_pdev = of_find_device_by_node(code
c_np);
| ^~~~~~~~~~~~~~~~~~~~~~
| of_find_i2c_device_by_node
/build/stage/linux/sound/soc/fsl/imx-rpmsg.c:60:44: error: assignment to ‘struct
platform_device *’ from ‘int’ makes pointer from integer without a cast [-Werro
r=int-conversion]
60 | codec_pdev = of_find_device_by_node(codec_np);
| ^
cc1: all warnings being treated as errors

Attachment: signature.asc
Description: PGP signature