Re: [PATCH v9 2/2] arm64: dts: qcom: sm8250-xiaomi-pipa: Add initial device tree

From: Konrad Dybcio
Date: Mon Nov 20 2023 - 09:30:27 EST


On 24.10.2023 08:37, Luka Panio wrote:
> Initial support for Xiaomi Pad 6 tablet, that have sm8250 soc.
>
> Signed-off-by: Luka Panio <lukapanio@xxxxxxxxx>
> ---
[...]

> +
> + gpio_keys: gpio-keys {
> + compatible = "gpio-keys";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&vol_up_n>;
property-n
property-names

other than that lgtm

Acked-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad