RE: [PATCH net-next v11 05/13] net:ethernet:realtek:rtase: Implement hardware configuration function

From: Justin Lai
Date: Mon Nov 20 2023 - 08:23:44 EST


> On Wed, 15 Nov 2023 21:34:06 +0800 Justin Lai wrote:
> > + .ndo_vlan_rx_add_vid = rtase_vlan_rx_add_vid,
> > + .ndo_vlan_rx_kill_vid = rtase_vlan_rx_kill_vid, #ifdef
> > +CONFIG_NET_POLL_CONTROLLER
> > + .ndo_poll_controller = rtase_netpoll, #endif
> > + .ndo_setup_tc = rtase_setup_tc,
>
> This patch is still way too huge. Please remove more functionality from the
> initial version of the driver. You certainly don't need VLAN support or CBS
> offload to pass packets.

Thanks for your review, I will remove some less necessary functions and make the patch smaller.