Re: [PATCH 14/14] arm: multi_v7_defconfig: Enable CONFIG_RAVB

From: claudiu beznea
Date: Mon Nov 20 2023 - 04:05:31 EST




On 20.11.2023 10:58, Geert Uytterhoeven wrote:
> On Mon, Nov 20, 2023 at 9:44 AM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>> On Mon, Nov 20, 2023, at 08:00, Claudiu wrote:
>>> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>>>
>>> ravb driver is used by RZ/G1H. Enable it in multi_v7_defconfig.
>
> Used by:
> - iWave-RZ/G1M/G1N Qseven carrier board,
> - iWave-RZ/G1H Qseven board,
> - iWave-RZG1E SODIMM carrier board,
> - iWave-RZ/G1C single board computer.
>
> So I'd write "used by various iWave RZ/G1 development boards".

OK, I'll update it in v2.

I noticed it is needed while checking various bits on a RZ/G1H based board
so I considered that if there is at least one user for it it is enough to
have it enabled.

Thank you,
Claudiu Beznea

>
>>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>>
>> We have a mix of =y and =m for ethernet drivers, and usually
>> only have drivers built-in when they are frequently tested
>> with NFS root booting.
>>
>> Do you need this as well, or could it be =m instead?
>
> As the default chosen/bootargs for the iWave-RZ/G1M/G1N Qseven carrier
> board contains root=/dev/nfs, builtin is appropriate.
> The iWave-RZ/G1H Qseven board defaults to root=/dev/mmcblk0p1.
>
> Gr{oetje,eeting}s,
>
> Geert
>