Re: [PATCH] docs: dt-bindings: add DTS Coding Style document

From: Krzysztof Kozlowski
Date: Mon Nov 20 2023 - 02:14:45 EST


On 16/11/2023 22:27, Conor Dooley wrote:
> On Thu, Nov 16, 2023 at 07:12:18PM +0100, Krzysztof Kozlowski wrote:
>> Document preferred coding style for Devicetree sources (DTS and DTSI),
>> to bring consistency among all (sub)architectures and ease in reviews.
>
> This is a good idea IMO, thanks for writing it.
>
> Should we also mention in this about the expected breakdown of things
> between $soc.dtsi and $soc-$board.dtsi? There's commonly confusion about
> things like oscillators and where they belong - particularly when the
> SoC mandates that these oscillators be of a single frequency.
> It may seem obvious to us what goes where, but certainly contributors
> frequently get this wrong.

Sure, I can add a chapter about DTS/DTSI split.

Best regards,
Krzysztof