Re: [PATCH] docs: dt-bindings: add DTS Coding Style document

[Krzysztof Kozlowski]

On 16/11/2023 21:33, Heiko Stuebner wrote:

>> 	regulator-state-mem {
>> 		regulator-off-in-suspend;
>> 	};
>>
>> What exactly would be here misordered?
> 
> going with the vcc5v0_host regulator of the rk3588-quartzpro64 and
> 
> +1. compatible
> +2. reg
> +3. ranges
> +4. All properties with values
> +5. Boolean properties
> +6. status (if applicable)
> +7. Child nodes
> 
> we'd end up with
> 
>         vcc5v0_host: vcc5v0-host-regulator {
> /* 1. */        compatible = "regulator-fixed";
> /* 4. */        gpio = <&gpio4 RK_PB0 GPIO_ACTIVE_HIGH>;
>                 pinctrl-names = "default";
>                 pinctrl-0 = <&vcc5v0_host_en>;
>                 regulator-min-microvolt = <5000000>;
>                 regulator-max-microvolt = <5000000>;
>                 regulator-name = "vcc5v0_host";
>                 vin-supply = <&vcc5v0_usb>;
> /* 5. */        enable-active-high;
>                 regulator-always-on;
>                 regulator-boot-on;
>         };      
> 
> which I find somewhat counter-intuitive ;-) .

Yes, good point.

Best regards,
Krzysztof