Re: [PATCH v2 1/1] drm/mediatek: Fix errors when reporting rotation capability

[Shawn Sung (宋孝謙)]

Hi CK,

Yes, atomic commit can still work without rotation property in planes,
it only affects IGT's behavior (will fail). Since currently we didn't
receive IGT requests on platforms other than MT8188, will return 0
directly if the property is not defined. Thanks.

Regards,
Shawn

On Mon, 2023-11-06 at 05:55 +0000, CK Hu (胡俊光) wrote:
> Hi, Hsiao-chien:
> 
> On Mon, 2023-10-30 at 17:03 +0800, Hsiao Chien Sung wrote:
> > For CRTCs that doesn't support rotation should still return
> > DRM_MODE_ROTATE_0. Returns hardware capabilities accordingly.
> 
> The original code would not call drm_plane_create_rotation_property()
> to create rotation property if CRTC does not support rotation. I
> think
> this behavior is OK because not all drm driver call
> drm_plane_create_rotation_property() and it works. So ovl adaptor is
> not necessary to implement supported_rotations() callback function.
> If
> some OVL does not support rotation, you could return 0 directly.
> 
> Regards,
> CK
>