Re: [PATCH] scripts: clean up IA-64 code

From: Masahiro Yamada
Date: Sun Nov 19 2023 - 23:18:59 EST


On Mon, Nov 20, 2023 at 5:58 AM Nicolas Schier <nicolas@xxxxxxxxx> wrote:
>
> On Sat, Nov 18, 2023 at 05:13:34PM +0900 Masahiro Yamada wrote:
> > A little more janitorial work after commit cf8e8658100d ("arch: Remove
> > Itanium (IA-64) architecture").
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> > ---
> >
> > scripts/checkstack.pl | 3 ---
> > scripts/gdb/linux/tasks.py | 15 +++------------
> > scripts/head-object-list.txt | 1 -
> > scripts/kconfig/mconf.c | 2 +-
> > scripts/kconfig/nconf.c | 2 +-
> > scripts/package/kernel.spec | 6 ------
> > scripts/package/mkdebian | 2 +-
> > scripts/recordmcount.pl | 7 -------
> > scripts/xz_wrap.sh | 1 -
> > 9 files changed, 6 insertions(+), 33 deletions(-)
> >
>
> Thanks, looks good to me. Might you want to also remove replace the last
> references in the kbuild files?
>
> scripts/recordmcount.c uses cpp symbol EM_IA_64

Thanks, I will remove it too.

> Makefile contains two comments with examples naming IA64


Which line? I could not spot them.


> scripts/checkstack.pl still holds credits for its (now removed) IA64 port,
> but that might have been left by intention


I hesitate to touch the credit. So, this is intentional.




>
> Nevertheless:
>
> Reviewed-by: Nicolas Schier <nicolas@xxxxxxxxx>
>
> Kind regards,
> Nicolas



--
Best Regards
Masahiro Yamada