Re: [PATCH 12/34] wifi: intel: use atomic find_bit() API where appropriate

From: Johannes Berg
Date: Sun Nov 19 2023 - 15:00:44 EST


On Sat, 2023-11-18 at 07:50 -0800, Yury Norov wrote:
> iwlegacy and iwlwifi code opencodes atomic bit allocation/traversing by
> using loops.

That's really just due to being lazy though, it could use a non-atomic
__test_and_set_bit() would be just fine in all of this, there's always a
mutex held around it that protects the data.

Not that it means that the helper is _wrong_, it's just unnecessary, and
you don't have non-atomic versions of these, do you?

johannes