Re: [PATCH net-next v7 08/16] net: ethtool: Add a command to expose current time stamping layer

From: Jakub Kicinski
Date: Sat Nov 18 2023 - 21:24:30 EST


On Tue, 14 Nov 2023 12:28:36 +0100 Kory Maincent wrote:
> + ops->get_ts_info(dev, &ts_info);
> + if (ts_info.so_timestamping &
> + SOF_TIMESTAMPING_HARDWARE_MASK)
> + data->ts_layer = MAC_TIMESTAMPING;
> +
> + if (ts_info.so_timestamping &
> + SOF_TIMESTAMPING_SOFTWARE_MASK)
> + data->ts_layer = SOFTWARE_TIMESTAMPING;

How does this work? so_timestamping is capabilities, not what's
enabled now. So if driver supports SW stamping we always return
SOFTWARE?