Re: [PATCH v5 4/6] net: phy: at803x: add the function phydev_id_is_qca808x

From: Jakub Kicinski
Date: Sat Nov 18 2023 - 19:23:31 EST

Next message: Jakub Kicinski: "Re: [PATCH v5 3/6] net: phy: at803x: add QCA8084 ethernet phy support"
Previous message: Jakub Kicinski: "Re: [PATCH net-next 6/9] netlink: specs: Expand the pse netlink command with PoE interface"
In reply to: Luo Jie: "[PATCH v5 4/6] net: phy: at803x: add the function phydev_id_is_qca808x"
Next in thread: Jie Luo: "Re: [PATCH v5 4/6] net: phy: at803x: add the function phydev_id_is_qca808x"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sat, 18 Nov 2023 14:27:52 +0800 Luo Jie wrote:
> +static inline bool phydev_id_is_qca808x(struct phy_device *phydev)

Please drop the "inline" keyword. The compiler will decide what's best.

Next message: Jakub Kicinski: "Re: [PATCH v5 3/6] net: phy: at803x: add QCA8084 ethernet phy support"
Previous message: Jakub Kicinski: "Re: [PATCH net-next 6/9] netlink: specs: Expand the pse netlink command with PoE interface"
In reply to: Luo Jie: "[PATCH v5 4/6] net: phy: at803x: add the function phydev_id_is_qca808x"
Next in thread: Jie Luo: "Re: [PATCH v5 4/6] net: phy: at803x: add the function phydev_id_is_qca808x"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]