Re: [PATCH v4 2/3] arm64: dts: qcom: Add base qcm6490 idp board dts

From: Konrad Dybcio
Date: Fri Nov 17 2023 - 20:11:47 EST


On 17.11.2023 13:50, Komal Bajaj wrote:
> Add DTS for Qualcomm IDP platform using QCM6490 SoC.
> This adds debug uart, eMMC and usb support along with
> regulators found on this board.
>
> Signed-off-by: Komal Bajaj <quic_kbajaj@xxxxxxxxxxx>
> ---
[...]

> + gpio-reserved-ranges = <32 2>, <48 4>;
Please describe what these pins are for, so e.g.:

gpio-reserved-ranges = <32 2>, /* spaghetti cooker */
<48 4>; /* fingerprint scanner */

aside from that, LGTM

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad