Re: [PATCH v4 6/7] media: qcom: camss: Flag VFE-lites to support more VFEs

[Konrad Dybcio]

On 3.11.2023 13:29, Bryan O'Donoghue wrote:
> From: Matti Lehtimäki <matti.lehtimaki@xxxxxxxxx>
> 
> Some platforms such as SC7280 have three VFEs and two VFE-lites. Current
> code has hard-coded two as the maximum number of VFEs. Remove the
> hard-coded maximum number of VFEs to handle all possible combinations of
> VFEs and VFE-lites.
> 
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@xxxxxxxxx>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
[...]


> +inline bool vfe_is_lite(struct vfe_device *vfe)
> +{
> +	return vfe->camss->res->vfe_res[vfe->id].is_lite;
0_o

something something vfe could use a direct resource pointer

I hope there are no more hidden (esp. using magic literals) users of
this IS_LITE <=> idx > 2 logic, but old code never fails to disappoint

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad