Re: [PATCH v2 7/8] arm64: dts: qcom: sm8650-mtp: add interconnect dependent device nodes

From: Konrad Dybcio
Date: Fri Nov 17 2023 - 19:28:17 EST


On 6.11.2023 09:39, Neil Armstrong wrote:
> Now interconnect dependent devices are added in sm8650 DTSI,
> now enable more devices for the Qualcomm SM8650 MTP board:
> - PCIe
> - Display
> - DSPs
> - SDCard
> - UFS
> - USB role switch with PMIC Glink
>
> Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> ---
Little nits:

[...]

> &tlmm {
> gpio-reserved-ranges = <32 8>;
> +
> + sde_dsi_active: sde-dsi-active-state {
Dmitry voiced concerns about having the "SDE_" part here lately
is it part of the actual pin name (in the schematic)?

[...]

>
> &usb_1_dwc3 {
> - dr_mode = "peripheral";
> + dr_mode = "otg";
Isn't that the default?

Konrad