Re: [PATCH 7/7] rtlwifi: rtl8821ae: Access full PMCS reg and use pci_regs.h

From: Bjorn Helgaas
Date: Fri Nov 17 2023 - 17:48:47 EST


On Fri, Nov 17, 2023 at 11:44:25AM +0200, Ilpo Järvinen wrote:
> _rtl8821ae_clear_pci_pme_status() accesses the upper byte of the Power
> Management Control/Status register (PMCS) with literal 5 offset.
>
> Access the entire PMCS register using defines from pci_regs.h to
> improve code readability.
>
> While at it, remove the obvious comment and tweak debug prints
> slightly to not sound misleading.

OK, ignore my previous comments ;) I should read all the way through
before responding.