Re: [PATCH] pinctrl: as3722: Use devm_gpiochip_add_data() to simplify remove path

From: Andy Shevchenko
Date: Fri Nov 17 2023 - 16:17:35 EST

Next message: David Howells: "[PATCH v2 15/51] netfs: Extend the netfs_io_*request structs to handle writes"
Previous message: David Howells: "[PATCH v2 14/51] netfs: Export netfs_put_subrequest() and some tracepoints"
In reply to: Andrew Davis: "[PATCH] pinctrl: as3722: Use devm_gpiochip_add_data() to simplify remove path"
Next in thread: Andy Shevchenko: "Re: [PATCH] pinctrl: as3722: Use devm_gpiochip_add_data() to simplify remove path"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, Nov 16, 2023 at 04:30:45PM -0600, Andrew Davis wrote:
> Use devm version of gpiochip add function to handle removal for us.

Seems reasonable. Consider also to convert to dev_err_probe()
(in a separate change).

Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>

--
With Best Regards,
Andy Shevchenko

Next message: David Howells: "[PATCH v2 15/51] netfs: Extend the netfs_io_*request structs to handle writes"
Previous message: David Howells: "[PATCH v2 14/51] netfs: Export netfs_put_subrequest() and some tracepoints"
In reply to: Andrew Davis: "[PATCH] pinctrl: as3722: Use devm_gpiochip_add_data() to simplify remove path"
Next in thread: Andy Shevchenko: "Re: [PATCH] pinctrl: as3722: Use devm_gpiochip_add_data() to simplify remove path"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]