Re: [PATCH 2/3] fbdev: ssd1307fb: Change "solomon,page-offset" property default value

From: Andy Shevchenko
Date: Fri Nov 17 2023 - 16:15:28 EST


On Thu, Nov 16, 2023 at 07:07:38PM +0100, Javier Martinez Canillas wrote:
> This is used to specify the page start address offset of the display RAM.
>
> The value is used as offset when setting the page start address with the
> SSD130X_SET_PAGE_RANGE command, and the driver currently sets its value to
> 1 if the property is not present in the Device Tree.
>
> But the datasheet mentions that the value on reset for the page start is a
> 0, so it makes more sense to also have 0 as the default value for the page
> offset if the property is not present.
>
> In fact, using a default value of 1 leads to the display not working when
> the fbdev is attached to the framebuffer console.
>
> Reported-by: Sahaj Sarup <sahaj.sarup@xxxxxxxxxx>

Closes?
Fixes?

> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

--
With Best Regards,
Andy Shevchenko