[PATCH 06/14] spi: axi-spi-engine: use devm_request_irq()

From: David Lechner
Date: Fri Nov 17 2023 - 15:14:11 EST


This replaces request_irq() with devm_request_irq() in the AXI SPI
Engine driver. This simplifies the error path and removes the need to
call free_irq() in the remove function.

Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx>
---
drivers/spi/spi-axi-spi-engine.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-engine.c
index c18a4b34777e..81d7352d2b8b 100644
--- a/drivers/spi/spi-axi-spi-engine.c
+++ b/drivers/spi/spi-axi-spi-engine.c
@@ -520,7 +520,8 @@ static int spi_engine_probe(struct platform_device *pdev)
if (ret)
return ret;

- ret = request_irq(irq, spi_engine_irq, 0, pdev->name, host);
+ ret = devm_request_irq(&pdev->dev, irq, spi_engine_irq, 0, pdev->name,
+ host);
if (ret)
return ret;

@@ -533,24 +534,18 @@ static int spi_engine_probe(struct platform_device *pdev)

ret = spi_register_controller(host);
if (ret)
- goto err_free_irq;
+ return ret;

platform_set_drvdata(pdev, host);

return 0;
-err_free_irq:
- free_irq(irq, host);
- return ret;
}

static void spi_engine_remove(struct platform_device *pdev)
{
struct spi_controller *host = platform_get_drvdata(pdev);
- int irq = platform_get_irq(pdev, 0);

spi_unregister_controller(host);
-
- free_irq(irq, host);
}

static const struct of_device_id spi_engine_match_table[] = {

--
2.42.0