Re: [RFC PATCH 2/2] arm64: dts: qcom: qcm6490: Add qcm6490 idp and rb3 board

[Komal Bajaj]

On 11/4/2023 6:02 PM, Konrad Dybcio wrote:
> On 11/3/23 19:46, Komal Bajaj wrote:
> > Add qcm6490 devicetree file for QCM6490 IDP and QCM6490 RB3
> > platform. QCM6490 is derived from SC7280 meant for various
> > form factor including IoT.
> >
> > Supported features are, as of now:
> > * Debug UART
> > * eMMC (only in IDP)
> > * USB
> >
> > Co-developed-by: Naina Mehta <quic_nainmeht@xxxxxxxxxxx>
> > Signed-off-by: Naina Mehta <quic_nainmeht@xxxxxxxxxxx>
> > Signed-off-by: Komal Bajaj <quic_kbajaj@xxxxxxxxxxx>
> > ---
> [...]
>
> > +
> > +&sdhc_1 {
> > +    non-removable;
> > +    no-sd;
> > +    no-sdio;
> > +
> > +    vmmc-supply = <&vreg_l7b_2p952>;
> > +    vqmmc-supply = <&vreg_l19b_1p8>;
> I think you also need to add regulator-allow-set-mode and something
> something regulator allowed modes to VQMMC

Okay, will add properties "regulator-allow-set-load" and 
"regulator-allowed-modes" to regulator vreg_l19b_1p8.

> [...]
>
> > +    model = "Qualcomm Technologies, Inc. QCM6490 RB3";
> Is the name just "QCM6490 RB3"? One already exists, based on SDM845.

Yeah, I missed that, this board is RB3Gen2, will update that in next 
patchset.

Thanks
Komal

> Otherwise, this looks very good to me now, thanks.
>
> With these nits addressed:
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>
> Konrad