Re: [PATCH 1/2] phy: mapphone-mdm6600: fix an error code problem in phy_mdm6600_device_power_on

[Su Hui]

On 2023/11/16 19:26, Vinod Koul wrote:
> On 20-10-23, 17:14, Su Hui wrote:
> > When wait_for_completion_timeout() failed, error is assigned
> > '-ETIMEDOUT'. But this error code is never used. Return '-ETIMEDOUT'
> > directly to fix this problem.
> Where is patch 2/2?

Hi,

Sorry, I send a error patch 2/2 because of my carelessness.

This is the address of patch 2/2 which is irrelevant about this patch.

https://lore.kernel.org/all/7f81d365-0440-de01-8be4-9c8d3ab9d69c@xxxxxxxxxxxx/

Su Hui

> > Signed-off-by: Su Hui <suhui@xxxxxxxxxxxx>
> > ---
> >
> > I'm not sure that return directly is true or not, maybe need some
> > process before return directly.
> >
> >   drivers/phy/motorola/phy-mapphone-mdm6600.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c
> > index 1d567604b650..e84e3390bff0 100644
> > --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c
> > +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c
> > @@ -421,8 +421,8 @@ static int phy_mdm6600_device_power_on(struct phy_mdm6600 *ddata)
> >   			dev_info(ddata->dev, "Powered up OK\n");
> >   	} else {
> >   		ddata->enabled = false;
> > -		error = -ETIMEDOUT;
> >   		dev_err(ddata->dev, "Timed out powering up\n");
> > +		return -ETIMEDOUT;
> >   	}
> >   
> >   	/* Reconfigure mode1 GPIO as input for OOB wake */
> > --
> > 2.30.2