Re: [PATCH 06/11] iio: adc: Add QCOM PMIC5 Gen3 ADC bindings

From: Krzysztof Kozlowski
Date: Thu Nov 16 2023 - 06:47:16 EST


On 16/11/2023 04:23, Jishnu Prakash wrote:
> Hi Krzysztof,
>
> On 10/23/2023 12:06 PM, Krzysztof Kozlowski wrote:
>> On 23/10/2023 08:14, Jishnu Prakash wrote:
>>> Hi Krzysztof,
>>>
>>> On 7/9/2023 10:53 PM, Krzysztof Kozlowski wrote:
>>>
>>>>> reg:
>>>>> description: VADC base address in the SPMI PMIC register map
>>>>> - maxItems: 1
>>>>> + minItems: 1
>>>> Why? This does not make any sense. With previous patches it looks like
>>>> random set of changes.
>>> The idea here is to convey that reg can have multiple values for ADC5
>>> Gen3 as there can be more than one peripheral used for ADC, so there can
>>> be multiple base addresses. I'll try to make this more clear in the next
>>> patchset.
>> You cannot remove constraints from an entry.
>
>
> In this case, minItems: 1 will remain true for all other ADC devices
> documented here, but it will not be true for ADC5 Gen3, as this one can
> have multiple base addresses if more than one SDAM is used for ADC. I'll
> update this separately for each compatible, keeping it the same for the
> older ones, hope that should work.

BTW, you disagree with me and send new version 2 minutes later.
Basically you did not leave me any time to respond to you.

That's not how the process works.

Best regards,
Krzysztof