Re: [PATCH V2 3/3] dt-bindings: iio/adc: Move QCOM ADC bindings to iio/adc folder

From: Krzysztof Kozlowski
Date: Thu Nov 16 2023 - 06:44:25 EST


On 16/11/2023 04:26, Jishnu Prakash wrote:
> There are several files containing QCOM ADC macros for channel names
> right now in the include/dt-bindings/iio folder. Since all of these
> are specifically for adc, move the files to the
> include/dt-bindings/iio/adc folder.
>
> Also update all affected devicetree and driver files to fix compilation
> errors seen with this move and update documentation files to fix
> dtbinding check errors for the same.
>
> Signed-off-by: Jishnu Prakash <quic_jprakash@xxxxxxxxxxx>
> ---
> .../devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml | 4 ++--
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 +-
> .../devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml | 2 +-
> .../devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml | 6 +++---
> arch/arm64/boot/dts/qcom/pm2250.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pm6125.dtsi | 2 +-

NAK, bindings are always separate from the other changes.

Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.

Best regards,
Krzysztof