Re: [PATCH 3/4] clk: qcom: videocc-sm8150: Update the video_pll0_config

[Satya Priya Kakitapalli (Temp)]

On 11/10/2023 4:46 PM, Bryan O'Donoghue wrote:
> On 10/11/2023 06:50, Satya Priya Kakitapalli wrote:
> > Update the video_pll0_config to configure the test_ctl_hi and
> > test_ctl_hi1 values.
> >
> > Fixes: 5658e8cf1a8a ("clk: qcom: add video clock controller driver 
> > for SM8150")
> > Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@xxxxxxxxxxx>
> > ---
> >   drivers/clk/qcom/videocc-sm8150.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/clk/qcom/videocc-sm8150.c 
> > b/drivers/clk/qcom/videocc-sm8150.c
> > index 6a5f89f53da8..ddfe784fb9e1 100644
> > --- a/drivers/clk/qcom/videocc-sm8150.c
> > +++ b/drivers/clk/qcom/videocc-sm8150.c
> > @@ -33,6 +33,8 @@ static struct alpha_pll_config video_pll0_config = {
> >       .config_ctl_val = 0x20485699,
> >       .config_ctl_hi_val = 0x00002267,
> >       .config_ctl_hi1_val = 0x00000024,
> > +    .test_ctl_hi_val = 0x00000002,
> > +    .test_ctl_hi1_val = 0x00000020,
> >       .user_ctl_val = 0x00000000,
> >       .user_ctl_hi_val = 0x00000805,
> >       .user_ctl_hi1_val = 0x000000D0,
>
> It would be nice to get a better description of this change.
>
> Reading this - I can see it does an update but, the commit log should 
> contain what it is updating and why plus what effect the update will 
> have.
>
> Please update the commit log to capture that data and +cc me on the V2.

Sure will check and update.


Thanks,

Satya Priya

> ---
> bod