Re: [PATCH v2] net/tcp: use kfree_sensitive() instend of kfree() in two functions

From: Eric Dumazet
Date: Thu Nov 16 2023 - 03:44:26 EST


On Thu, Nov 16, 2023 at 3:22 AM Minjie Du <duminjie@xxxxxxxx> wrote:
>
> key might contain private information, so use kfree_sensitive to free it.
> In tcp_time_wait_init() and tcp_md5_twsk_free_rcu() use kfree_sensitive().
>
> Signed-off-by: Minjie Du <duminjie@xxxxxxxx>
> ---
>

You have not addressed my prior feedback.

3) You forgot tcp_time_wait_init(), tcp_md5_do_del(), tcp_md5_key_copy(),
tcp_md5_do_add(), tcp_clear_md5_list().