Re: [PATCH 03/11] ARM: dts: qcom: Update devicetree for ADC7 rename for QCOM PMICs

[Jishnu Prakash]

Hi Krzysztof,

On 11/10/2023 4:29 PM, Krzysztof Kozlowski wrote:
> On 09/11/2023 09:22, Jishnu Prakash wrote:
> > Hi Krzysztof,
> >
> > On 10/23/2023 12:02 PM, Krzysztof Kozlowski wrote:
> >
> > Since you do not want us to modify the existing bindings, is it fine if
> > I just add a new compatible for ADC5 Gen2 and comments to indicate the
> > ADC7 compatible should be considered deprecated?
> No, because adc7 compatible is valid and there is no reason to replace
> it. Just because you changed naming does not matter for compatibles.
> It's just unique string, that's it. Don't touch it.
>
>
> > If you are not convinced, we can drop the Gen2 name related changes from
> > the patch series.
> Feel free to add comments or descriptions, if you want to map some
> marketing name to real hardware or to compatibles.

Yes, I'll just add a line in the documentation to mention ADC7 goes 
between ADC5 and ADC5 Gen3.

Thanks,

Jishnu


> Best regards,
> Krzysztof