Re: [PATCH 0/3] bpf: kernel/bpf/task_iter.c: don't abuse next_thread()

From: Yonghong Song
Date: Wed Nov 15 2023 - 22:14:09 EST



On 11/14/23 11:32 AM, Oleg Nesterov wrote:
Compile tested.

Every lockless usage of next_thread() was wrong, bpf/task_iter.c is
the last user and is no exception.

It would be great if you can give more information in the commit message
about why the usage of next_thread() is wrong in bpf/task_iter.c.
IIUC, some information is presented in :
https://lore.kernel.org/all/20230824143112.GA31208@xxxxxxxxxx/

Also, please add 'bpf' in the subject tag ([PATCH bpf 0/3]) to
make it clear the patch should be applied to bpf tree.


Oleg.
---

kernel/bpf/task_iter.c | 29 +++++++++++------------------
1 file changed, 11 insertions(+), 18 deletions(-)