Re: [PATCH] kasan: default to inline instrumentation

From: Joe Perches
Date: Wed Nov 15 2023 - 17:48:47 EST


On Wed, 2023-11-15 at 14:34 -0800, Andrew Morton wrote:
> On Tue, 14 Nov 2023 21:38:50 -0800 Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> > > +LIBRARY CODE
> > > +M: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > > +L: linux-kernel@xxxxxxxxxxxxxxx
> > > +S: Supported
> >
> > Dunno.
> >
> > There are a lot of already specifically maintained or
> > supported files in lib/
>
> That's OK. I'll get printed out along with the existing list of
> maintainers, if any.
>
> > Maybe be a reviewer?
>
> Would that alter the get_maintainer output in any way?

Not really. It would allow someone to avoid cc'ing reviewers
and not maintainers though.

Perhaps change the
S: Supported
to something like
S: Supported for the files otherwise not supported

> I suppose I could list each file individually, but I'm not sure what
> that would gain.
>
> btw, I see MAINTAINERS lists non-existent file[s] (lib/fw_table.c).
> Maybe someone has a script to check...

--self-test works

$ ./scripts/get_maintainer.pl --self-test=patterns
./MAINTAINERS:3653: warning: no file matches F: Documentation/devicetree/bindings/iio/imu/bosch,bma400.yaml
./MAINTAINERS:6126: warning: no file matches F: Documentation/devicetree/bindings/watchdog/da90??-wdt.txt
./MAINTAINERS:10342: warning: no file matches F: drivers/iio/light/gain-time-scale-helper.c
./MAINTAINERS:10343: warning: no file matches F: drivers/iio/light/gain-time-scale-helper.h
./MAINTAINERS:22062: warning: no file matches F: arch/arm/boot/dts/imx*mba*.dts*
./MAINTAINERS:22063: warning: no file matches F: arch/arm/boot/dts/imx*tqma*.dts*
./MAINTAINERS:22064: warning: no file matches F: arch/arm/boot/dts/mba*.dtsi

and: see commit a103f46633fdcddc2aaca506420f177e8803a2bd

$ git log --stat -1 a103f46633fdcddc2aaca506420f177e8803a2bd
commit a103f46633fdcddc2aaca506420f177e8803a2bd
Author: Dave Jiang <dave.jiang@xxxxxxxxx>
Date: Thu Oct 12 11:53:54 2023 -0700

acpi: Move common tables helper functions to common lib

Some of the routines in ACPI driver/acpi/tables.c can be shared with
parsing CDAT. CDAT is a device-provided data structure that is formatted
similar to a platform provided ACPI table. CDAT is used by CXL and can
exist on platforms that do not use ACPI. Split out the common routine
from ACPI to accommodate platforms that do not support ACPI and move that
to /lib. The common routines can be built outside of ACPI if
FIRMWARE_TABLES is selected.

Link: https://lore.kernel.org/linux-cxl/CAJZ5v0jipbtTNnsA0-o5ozOk8ZgWnOg34m34a9pPenTyRLj=6A@xxxxxxxxxxxxxx/
Suggested-by: "Rafael J. Wysocki" <rafael@xxxxxxxxxx>
Reviewed-by: Hanjun Guo <guohanjun@xxxxxxxxxx>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Signed-off-by: Dave Jiang <dave.jiang@xxxxxxxxx>
Acked-by: "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>
Link: https://lore.kernel.org/r/169713683430.2205276.17899451119920103445.stgit@djiang5-mobl3
Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>

MAINTAINERS | 2 ++
drivers/acpi/Kconfig | 1 +
drivers/acpi/tables.c | 173 -------------------------------------------------------------------------------------------------------
include/linux/acpi.h | 42 +++++++------------------
include/linux/fw_table.h | 43 ++++++++++++++++++++++++++
lib/Kconfig | 3 ++
lib/Makefile | 2 ++
lib/fw_table.c | 189 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
8 files changed, 251 insertions(+), 204 deletions(-)