Re: [PATCH 2/3] drm/tests: Use KUNIT_DEFINE_ACTION_WRAPPER()
From: Maxime Ripard
Date: Wed Nov 15 2023 - 10:51:37 EST
Hi David,
On Sat, Nov 11, 2023 at 04:08:27AM +0800, David Gow wrote:
> In order to pass functions to kunit_add_action(), they need to be of the
> kunit_action_t type. While casting the function pointer can work, it
> will break control-flow integrity.
>
> drm_kunit_helpers already defines wrappers, but we now have a macro
> which does this automatically. Using this greatly reduces the
> boilerplate needed.
>
> Signed-off-by: David Gow <davidgow@xxxxxxxxxx>
> ---
>
> This patch should be a no-op, just moving to use a standard macro to
> implement these wrappers rather than hand-coding them.
>
> Let me know if you'd prefer to take these in separately via the drm
> trees, or if you're okay with having this whole series go via
> kselftest/kunit.
You can merge it through your tree with
Acked-by: Maxime Ripard <mripard@xxxxxxxxxx>
For the patches 2 and 3
Maxime
Attachment:
signature.asc
Description: PGP signature